Here's a version with a few improvements.
Don't include your user name in the script, use ~ to refer to your home directory.
Store the name of the results directory in a variable. This illustrates how to use a variable in a shell script.
Make the part that removes the result of a previous search more robust: it won't remove anything that's not a symbolic link.
The most important: your version would fail with file names containing spaces or some special characters, because the shell does some reparsing of the result of $(...) and $file. You should always put variable substitutions in double quotes (i.e., write "$file"). My version works correctly with all file names (except if they contain newlines, but that's inescapable with locate).
#!/bin/bash
results_dir=~/Desktop/results
mkdir -p "$results_dir"
find "$results_dir" -type l -exec rm {} +
echo "Please enter some input: "
read -r input_variable
locate "$input_variable" | while read -r line; do
ln -s "$line" "$results_dir/"
done