11

I want to process many files and since I've here a bunch of cores I want to do it in parallel:

for i in *.myfiles; do do_something $i `derived_params $i` other_params; done

I know of a Makefile solution but my commands needs the arguments out of the shell globbing list. What I found is:

> function pwait() {
>     while [ $(jobs -p | wc -l) -ge $1 ]; do
>         sleep 1
>     done
> }
>

To use it, all one has to do is put & after the jobs and a pwait call, the parameter gives the number of parallel processes:

> for i in *; do
>     do_something $i &
>     pwait 10
> done

But this doesn't work very well, e.g. I tried it with e.g. a for loop converting many files but giving me error and left jobs undone.

I can't belive that this isn't done yet since the discussion on zsh mailing list is so old by now. So do you know any better?

3
  • Similar to this question: superuser.com/questions/153630/… See if that technique works for you.
    – JRobert
    Jun 29, 2010 at 15:44
  • It would be helpful if you posted the error messages. Jun 29, 2010 at 17:46
  • @JRobert yes I knew this but this doesn't actually helps as the makefile approach won't work as I said! @Dennis: Ok, first I let run a top beside showing me more than the specified number of processes. Second it doesn't return to the prompt properly. Third that I said it leaves jobs undone was not right: I just placed an indicator echo "DONE" after the loop which was executed before active jobs aren't finished. => This made me think that jobs werent done.
    – math
    Jun 30, 2010 at 8:26

5 Answers 5

15

A makefile is a good solution to your problem. You could program this parallel execution in a shell, but it's hard, as you've noticed. A parallel implementation of make will not only take care of starting jobs and detecting their termination, but also handle load balancing, which is tricky.

The requirement for globbing is not an obstacle: there are make implementations that support it. GNU make, which has wildcard expansion such as $(wildcard *.c) and shell access such as $(shell mycommand) (look up functions in the GNU make manual for more information). It's the default make on Linux, and available on most other systems. Here's a Makefile skeleton that you may be able to adapt to your needs:

sources = $(wildcard *.src)

all: $(sources:.src=.tgt)

%.tgt: %.src
    do_something $< $$(derived_params $<) >$@

Run something like make -j4 to execute four jobs in parallel, or make -j -l3 to keep the load average around 3.

9

I am not sure what your derived arguments are like. But with GNU Parallel http:// www.gnu.org/software/parallel/ you can do this to run one job per cpu core:

find . | parallel -j+0 'a={}; name=${a##*/}; upper=$(echo "$name" | tr "[:lower:]" "[:upper:]");
   echo "$name - $upper"'

If what you want to derive is simply changing the .extension the {.} may be handy:

parallel -j+0 lame {} -o {.}.mp3 ::: *.wav

Watch the intro video to GNU Parallel at http://www.youtube.com/watch?v=OpaiGYxkSuQ

1
  • Sounds great but your video has no content about parallel. I don't understand about you got the pipe content
    – guhur
    Oct 6, 2021 at 7:14
7

Wouldn't using the shell's wait command work for you?

for i in *
do
    do_something $i &
done
wait

Your loop executes a job then waits for it, then does the next job. If the above doesn't work for you, then yours might work better if you move pwait after done.

4
  • no with 1 million files I would have 1 million processes running, or am I wrong?
    – math
    Jun 29, 2010 at 19:12
  • 1
    @brubelsabs: Well, it would try to do a million processes. You didn't say in your question how many files you needed to process. I would think you'd need to use nested for loops to limit that: for file in *; do for i in {1..10}; do do_something "$i" & done; wait; done (untested) That should do ten at a time and wait until all ten of each group is done before starting the next ten. Your loop does one at a time making the & moot. See the question that JRobert linked to for other options. Search on Stack Overflow for other questions similar to yours (and that one). Jun 29, 2010 at 23:12
  • If the OP anticipates a million of files then he would have a problem with for i in *. He would have to pass arguments to the loop with a pipe or something. Then instead of an internal loop you could run an incrementing counter and run "micro-"wait"-s" every "$((i % 32))" -eq '0'
    – user60570
    Dec 27, 2010 at 22:15
  • @DennisWilliamson: combining wait with an inner counter loop worked well for me. Thanks!
    – Joel Purra
    May 21, 2014 at 8:50
3

Why has nobody mentioned xargs yet?

Assuming you have exactly three arguments,

for i in *.myfiles; do echo -n $i `derived_params $i` other_params; done | xargs -n 3 -P $PROCS do_something

Otherwise use a delimiter (null is handy for that):

for i in *.myfiles; do echo -n $i `derived_params $i` other_params; echo -ne "\0"; done | xargs -0 -n 1 -P $PROCS do_something

EDIT: for the above, each parameter should be separated by a null character, and then the number of parameters should be specified with the xargs -n.

1
  • Yes in our project someone have had the same idea, and it works great even under Windows with MSys.
    – math
    Aug 10, 2011 at 10:11
0

I tried some of the answers. They make the script a bit more complex than that is needed. Ideally using parallel or xargs would be preferable however if the operations inside the for loop is complicated it could be problematic to create a big and long lines files to supply to parallel. instead we could use source as follows

# Create a test file 
$ cat test.txt
task_test 1
task_test 2

# Create a shell source file 
$ cat task.sh
task_test()
{
    echo $1
}

# use the source under bash -c 
$ cat test.txt | xargs -n1 -I{} bash -c 'source task.sh; {}'
1
2

Thus for your problem solution would look like

for i in *.myfiles; echo " do_something $i `derived_params $i` other_params
" >> commands.txt ; done

define do something as do_something.sh

do_something(){
process $1
echo $2 
whatever $3 

}

execute with xarg or gnu parallel

   cat commands.txt | xargs -n1 -I{} -P8 bash -c 'source do_something.sh; {}'

I assume functional independence of iterations of for is implied.

You must log in to answer this question.

Not the answer you're looking for? Browse other questions tagged .