batch file put if inside for loop error

Question

I have a working for loop to print all zip file's name under one working directory:

@echo off
setlocal

for %%i in (*.zip) do (
    echo %%i
    )

I have another working if block to check and print out a zip file size :

echo set FileSize=%%~z1 > %temp%\GetFileSize.bat
call %temp%\GetFileSize  "720P_1500K_101399042.zip"
if %FileSize% GTR 1000 (
    echo %FileSize% is greater than 1000
    ) else (
    echo %FileSize% is NOT greater than 1000
    )

Now, I am trying to combine these two pieces together to have a for loop to get all zip files under the working directory and at the same time use the if block to check the file size and then print out the size. But I was told: 1000 was unexpected at this time. why?

for %%i in (*.zip) do (
    echo %%i
    echo set FileSize=%%~z1 > %temp%\GetFileSize.bat
    call %temp%\GetFileSize  "%%i"
    if %FileSize% GTR 1000 (
        echo %FileSize% is greater than 1000
    ) else (
        echo %FileSize% is NOT greater than 1000
    )
    )

Answer 1

I will use powershell for this:

Get-ChildItem "Filepath" -Filter *.zip | ForEach {
  "$_.Name"
  If($_.Length -gt 1000){
    Write-Host "$($_.Length) is greater than 1000"
  }
  Else {
    Write-Host "$($_.Length) is NOT greater than 1000"
  }
}

Or if you strictly want to use batch, then why pass it to another batch file? Directly do it:

@echo off
setlocal
for %%i in (*.zip) do (
    echo %%i
    if %%~zi GTR 1000 (
        echo %%~zi is greater than 1000
    ) else (
        echo %%~zi is NOT greater than 1000
    )
)

Answer 2

You can try something like:

• For to accept your arguments (%1, %2, %3, %n...) and echoing name and size:

@echo off && setlocal enabledelayedexpansion

if not "%~x1" == ".zip" (
     set "_loops=*.zip" ) else set "_loops=%*" 
     
set^ "_bit=is greater" && for %%i in (!_loops!) do (
     if not %%~zi gtr 1000 set "_bit=!_bit: = NOT !"
     echo\File %%~nxi ^| Size %%~zi !_bit! than 1000
     set "_bit=is greater"
   )

endlocal && goto=:EOF

• Little more simple and with arguments too:

@echo off

if not "%~x1"==".zip" (
     set "_zip=*.zip") else set "_zip=%*" 
     
for %%i in (%_zip%)do if %%~zi gtr 1000 (
     echo\%%~zi is greater than 1000
     )else echo\%%~zi is NOT greater

• One option that only echoing name and size:

@echo off && setlocal enabledelayedexpansion

set^ "_bit=is greater" &&  for %%i in ("*.zip") do (
     if not %%~zi gtr 1000 set "_bit=!_bit: = NOT !"
     echo\File %%~nxi ^| Size %%~zi !_bit! than 1000
     set "_bit=is greater"
   )

endlocal && goto=:EOF

---

• Copy file if is greater:

@echo off 

set "_bit=is greater"
setlocal enabledelayedexpansion
   
for %%i in ("*.zip")do if %%~zi gtr 1000 (
   copy /b "file" + "%%~fi" "%%~dpni_new%%~xi" 2>nul 
   echo\File %%~nxi ^| Size %%~zi !_bit! than 1000 ) else ( 
   echo\File %%~nxi ^| Size %%~zi !_bit: = NOT ! than 1000 )

endlocal && goto=:EOF

• Copy file if is NOT greater:

@echo off

set "_bit=is greater"
setlocal enabledelayedexpansion

for %%i in ("*.zip")do if %%~zi leq 1000 (
   copy /b "file" + "%%~fi" "%%~dpni_new%%~xi" 2>nul 
   echo\File %%~nxi ^| Size %%~zi !_bit: = NOT ! than 1000
   ) else ;echo\File %%~nxi ^| Size %%~zi !_bit! than 1000

endlocal && goto=:EOF

---

For PowerShell

Get-Item "D:\Folder\*.zip"|foreach-object { if ($_.Length -gt 1000) 
  { Write-Host $_.Length is greater than 1000 } else { 
    Write-Host $_.Length is NOT greater than 1000 }}

• Or, with aliases:

 gi "D:\Folder\*.zip" | ? { if ( $_.Length -gt 1000 ) 
  { write-host $_.Length is greater than 1000 } else { 
     write-host $_.Length is NOT greater than 1000 } }